Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2460 Add tests for S2S tests using SSL #1869

Closed
wants to merge 1 commit into from

Conversation

lordgamez
Copy link
Contributor

  • Add tests with both yml and json config, and with both controller property and minifi.properties file configuration
  • Fix RPG port properties with JSON flow config
  • Add verbose curl debug logs for S2S communication
  • Remove redundant feature_id in test modules
  • Create test certificate files on test feature level

https://issues.apache.org/jira/browse/MINIFICPP-2460


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@@ -292,6 +292,7 @@ std::pair<std::string, int> RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo
if (!token.empty())
client->setRequestHeader("Authorization", token);

client->setVerbose(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment clarifying that these logs go to the debug level.

Suggested change
client->setVerbose(false);
// verbose logs are logged at debug level
client->setVerbose(/* use_stderr: */ false);

@szaszm szaszm closed this in 0359e1b Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants