xtensa/esp32s3: Add timing delay set interface for QSPI#13277
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Sep 5, 2024
Merged
xtensa/esp32s3: Add timing delay set interface for QSPI#13277xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi @Kevin-Zhou11 , thanks for the submission! I will test it on our internal CI. Please wait to merge it. |
tmedicci
reviewed
Sep 3, 2024
Contributor
tmedicci
left a comment
There was a problem hiding this comment.
Internal CI testing passed successfully. Where are these interfaces are being used?
acassis
reviewed
Sep 3, 2024
Contributor
Author
|
@tmedicci, thanks for your review.
Our project has timing delayed issue, I call this interface in slave driver (such lan9250) after qspi initialize, below is an example. |
c93b2af to
787abbf
Compare
Contributor
Author
|
@acassis, thanks for your review. I have fixed the alignment issue, please check. |
acassis
approved these changes
Sep 4, 2024
xiaoxiang781216
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When esp32s3 read from slave device through qspi, the data input signal has timing delay compared to clock signal, the higher the SPI frequency, the more impact to SPI sampling data, cause to receive wrong data.
esp32s3 has SPI timing compensation for this Scenario, add interface qspi driver to set timing compensation for the delay.
Impact
No impact
Testing
Build with esp32s3-devkit, test with project board.