nrf91: Update GPS to GNSS#13548
Merged
xiaoxiang781216 merged 2 commits intoapache:masterfrom Sep 20, 2024
Merged
Conversation
Related: 03f4ec7 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
|
[Experimental Bot, please feedback here] The PR appears to meet the basic NuttX requirements, but could benefit from more details in a few areas: Strengths:
Areas for Improvement:
Recommendation: Expand on the "Impact" and "Testing" sections with the details mentioned above. This will make your PR stronger and easier for reviewers to assess. |
Log:
Untracked files:
(use "git add <file>..." to include in what will be committed)
libs/libc/gnssutils/db46128e73cee26d6a6eb0482dcba544ee1ea9f5.zip
nothing added to commit but untracked files present (use "git add" to track)
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
8858257 to
622ddb5
Compare
Contributor
Author
|
Details for 622ddb5(libs/gnssutils: Ignore source zip): but libs/libc/gnssutils/CMakeLists.txt may not |
xiaoxiang781216
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update GPS to GNSS.
Impact
nrf91: arch/boards
Testing