Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc/lib_utsname: Store version number for debugging and preventing optimization #14057

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 10, 2024

Summary

  1. In order to directly read the version information of the current file from elf or bin files, memory files, etc., for easy debugging and one-to-one correspondence.

Impact

None

Testing

None

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Oct 10, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 10, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:

    • Lacks specifics about the change. What functional part of the code is being modified? How does the change work?
    • No mention of related issues or pull requests.
  • Impact:

    • The impact section claims "None" across the board. This is highly unlikely for any code change. Every change has some impact. Be specific.
    • Consider:
      • Does this change add new functions or data structures?
      • Does it modify existing code paths?
      • Are there potential performance implications?
  • Testing:

    • "None" is unacceptable. Every PR needs evidence of testing.
    • Provide details about your build host(s) and target(s) as specified in the requirements.
    • Include relevant testing logs demonstrating the issue before the change and the correct behavior after.

Recommendations:

  1. Elaborate on the Summary: Clearly describe the technical details of your changes.
  2. Analyze the Impact: Thoroughly assess and document the impact of your changes, even if they seem minor.
  3. Provide Testing Evidence: Demonstrate that your changes work as intended with specific testing details and logs.

A well-documented PR makes it easier for maintainers to understand, review, and merge your contribution.

@acassis
Copy link
Contributor

acassis commented Oct 10, 2024

@W-M-R please copy the comment from Summary to the commit log message

…ptimization

In order to directly read the version information of the current file from elf or bin files, memory files, etc., for easy debugging and one-to-one correspondence.

Signed-off-by: wangmingrong1 <[email protected]>
@W-M-R
Copy link
Contributor Author

W-M-R commented Oct 11, 2024

@W-M-R please copy the comment from Summary to the commit log message

OK

@W-M-R W-M-R force-pushed the utsname branch 5 times, most recently from 4568d71 to 0c5169d Compare October 11, 2024 13:39
@W-M-R W-M-R force-pushed the utsname branch 2 times, most recently from ea25b30 to c9e9b5c Compare October 11, 2024 14:49
@xiaoxiang781216 xiaoxiang781216 merged commit 6e12b3d into apache:master Oct 12, 2024
37 checks passed
@W-M-R W-M-R deleted the utsname branch October 14, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants