arch/intel64_cpustart.c add missing spinlock include #14102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: x86_64
fixes gcc 14 error: chip/intel64_cpustart.c:88:3: error: implicit declaration of function ‘SP_DMB’ [-Wimplicit-function-declaration] 88 | SP_DMB(); Signed-off-by: p-szafonimateusz <[email protected]>
xiaoxiang781216
approved these changes
Oct 11, 2024
| #include <nuttx/arch.h> | ||
| #include <nuttx/spinlock.h> |
There was a problem hiding this comment.
why change the oder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
fixes gcc 14 error:
chip/intel64_cpustart.c:88:3: error: implicit declaration of function ‘SP_DMB’ [-Wimplicit-function-declaration]
88 | SP_DMB();
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
no impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.
ostest