Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: CI Docker adds Python package installation #14117

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 11, 2024

Summary

  1. Add Python tool 'install CI' to MSYS2 platform
  2. CI Python Add Package Construction
  3. boards/qemu: Open kasan on qemu #14055 patch can't merge because docker file should be merged so it can take effect

Impact

NO

Testing

NO

@github-actions github-actions bot added Area: Tooling Area: CI Size: S The size of the change in this PR is small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • The summary lacks details about the "change" itself. What does "Add Python tool 'install CI' to MSYS2 platform" actually entail? What specific changes were made?
    • The functionality impacted by the change is unclear.
    • How the change works is not explained.
    • While there's a PR reference, it's unclear how points 1 & 2 relate to the patch in the PR.
  • Impact:
    • Simply stating "NO" for all impact points is insufficient. Even if there's no impact, a brief justification is needed. For example, "Impact on build (will build process change)? NO - The change is isolated to the CI environment and doesn't affect the project's build process."
  • Testing:
    • "NO" is not acceptable. Provide details about your testing environment and the results observed before and after the change. Even if the change is primarily related to CI, you should have tested it locally to ensure it works as expected.

Recommendations:

  1. Expand the Summary: Provide a clear and concise explanation of the change, its purpose, and how it was implemented.
  2. Justify Impact: For each impact point, even if it's "NO", provide a brief explanation.
  3. Provide Testing Details: Describe your local setup, the tests you performed, and the results observed both before and after applying your changes. Include relevant logs or output.

By providing the missing information, you'll make your PR much easier for reviewers to understand and approve.

@W-M-R W-M-R force-pushed the CI branch 4 times, most recently from a9213c0 to 95a34be Compare October 12, 2024 08:18
1. Add Python tool 'install CI' to MSYS2 platform
2. CI Python Add Package Construction

Signed-off-by: wangmingrong1 <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit c9db6e8 into apache:master Oct 12, 2024
38 checks passed
@W-M-R W-M-R deleted the CI branch October 14, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Tooling Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants