Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esptool version on docs and build system #14120

Conversation

fdcavalcanti
Copy link
Contributor

Follows #13824

Summary

This PR updates all esptool version references from development to latest.
A second issue regarding older esptool versions causing the build to silently fail will be addressed in a different PR due to test requirements.

Impact

Espressif devices documentation and pip install sections of the build system.

Testing

Internal CI build.

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Area: Tooling Area: CI Size: S The size of the change in this PR is small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

Yes, the PR meets the NuttX requirements.

It includes all the required sections (Summary, Impact, Testing) and provides sufficient information within each section:

  • Summary: Explains the "why" and "what" of the change.
  • Impact: Clearly outlines the specific parts of the codebase affected (documentation, build system).
  • Testing: States the testing method (CI) and indirectly addresses target (Espressif devices) through context.

The PR also links a related issue (#13824) which further aids in understanding the context and necessity of the changes.

@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 11, 2024 that may be closed by this pull request
1 task
@xiaoxiang781216 xiaoxiang781216 merged commit a157436 into apache:releases/12.7 Oct 11, 2024
30 checks passed
@cederom
Copy link
Contributor

cederom commented Oct 11, 2024

Thank you @fdcavalcanti !! :-)

@jerpelea
Copy link
Contributor

jerpelea commented Oct 15, 2024

replaced by #14267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Documentation Improvements or additions to documentation Area: Tooling Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ESP32: esptool below 4.8 silently produces broken firmware.
5 participants