Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuttx/syscall: export nxsem_getprioceiling and nxsem_setprioceiling v… #14129

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

ThePassionate
Copy link

@ThePassionate ThePassionate commented Oct 11, 2024

Summary

  1. fix compilation errors when compiling priority protection interfaces in protected mode with pthread_mutex_setprioceiling and pthread_mutex_getprioceiling
  2. can use the default lock even in priority protect mode

Impact

compile & ltp

Testing

ci

@github-actions github-actions bot added Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small labels Oct 11, 2024
@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Size: XS The size of the change in this PR is very small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

This PR appears to be missing some required information.

Here's a breakdown:

What's Good:

  • Summary: Provides a brief description of the issue and the proposed solution.
  • Testing: Mentions "ci", indicating Continuous Integration testing is expected.

What Needs Improvement:

  • Summary:
    • Lacks specificity about the functional code changes. Phrases like "compilation errors" and "use the default lock" are vague.
    • Missing related issue references (if applicable).
  • Impact:
    • Overly brief. "compile & ltp" doesn't explain the impact clearly.
    • Needs to address all impact points with "YES/NO" and explanations. For example:
      • Is new feature added? Likely NO (since it's a fix)
      • Is existing feature changed? Likely YES (since a fix implies a change) - provide details.
      • Impact on user: Explain how the fix might affect users.
      • Impact on build: If the fix affects the build process, describe how.
      • ...and so on for all impact points.
  • Testing:
    • "ci" is not sufficient. While CI is good, the PR should include:
      • Specific build host details (OS, CPU, compiler).
      • Specific target details (architecture, board, configuration).
      • Relevant testing logs from before and after the change to demonstrate the fix.

Recommendation:

Expand on the missing information to meet the NuttX PR requirements fully. Providing clear and detailed information ensures reviewers can understand the changes and their implications effectively.

@xiaoxiang781216 xiaoxiang781216 merged commit b272729 into apache:master Oct 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants