Unify the definition of GCCVER and remove duplicate code. #14159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Tooling
Area: Build system
Arch: arm
|
[Experimental Bot, please feedback here] I need the content of the PR to assess if it meets the NuttX requirements. Please provide the following:
With this information, I can review the PR against the NuttX requirements and provide a concise assessment. |
xuxin930
reviewed
Oct 12, 2024
|
@anchao @xiaoxiang781216 please review this patch to resolve #14130 (comment) |
|
hi @anchao please review whether this location is reasonable. |
anchao
approved these changes
Oct 12, 2024
Signed-off-by: cuiziwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing