draft driver for STUSB4500#14895
Conversation
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing:
By addressing these points, the PR will be much more likely to be accepted. Remember to be clear, concise, and provide as much detail as possible. |
90c9862 to
e035f45
Compare
e035f45 to
2531052
Compare
|
@SimonFilgis please fix these coding style issues: |
d14f2db to
e48b4a1
Compare
|
https://github.com/ardnew/STUSB4500/blob/master/LICENSE I think I should add the license to nuttx/LICENSE... I took over defines and structs. The algorithm is from the STM app note. Is there an opinion about that? |
|
Hi Simon,
Normally headers files are not covered by the license (at least for GPL), I
think you can use the Apache license and put a note explaining that the
definitions came from that project.
BR,
Alan
…On Sun, Nov 24, 2024 at 2:45 PM SimonFilgis ***@***.***> wrote:
https://github.com/ardnew/STUSB4500/blob/master/LICENSE
I think I should add the license to nuttx/LICENSE...
I took over defines and structs. The algorithm is from the STM app note.
Is there an opinion about that?
—
Reply to this email directly, view it on GitHub
<#14895 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJBCAOXY3LVGH26TEPMRT2CIGFPAVCNFSM6AAAAABSHMITK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGEZTGMRRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
e48b4a1 to
58effcf
Compare
|
@SimonFilgis please squash your commit and remove the draft from title when done |
right now it is only possible to change the delivered power on the fly by 1. selecting PDO2 slot 2. write to POO2 3. renegotiate power delivery by sw reset command
3b6d4b2 to
3efe941
Compare
Add: - ST standalone USB PD sink controller apache#14895 Signed-off-by: simbit18 <simbit18@gmail.com>
Add: - ST standalone USB PD sink controller apache#14895 Signed-off-by: simbit18 <simbit18@gmail.com>
Add: - ST standalone USB PD sink controller #14895 Signed-off-by: simbit18 <simbit18@gmail.com>
Right now it is only possible to change the delivered power on the fly by
Note: Please adhere to Contributing Guidelines.
Summary
Create a basic driver to negotiate power delivery with walladapter using STM STUSB4500 chip.
This is a standalone driver that does not change any other code. It may be selected, or not via kconfig.
Impact
New feature. No impact to any existing user or application expected.
Testing
Tested on custom board.