-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs/littlefs: stop applying local patches for unknown versions of littlefs #14956
Conversation
…lefs Because they are not expected to apply cleanly. In that case, disable all features which require the local patches. Note: lfs_util.patch is actually necessary regardless of the littlefs version. It should be ok to drop it for the simplest flat memory model configurations with a single heap though. I plan to fix it once littlefs 2.9.4 is released. Tested with esp32s3-devkitc:toywasm + CONFIG_FS_LITTLEFS_VERSION="v2.9.3".
I chose this config just because it seems to support cmake-based build.
I chose this config because I have a hardware and I occasionally use littlefs on its flash.
102e4ba
to
c44fa65
Compare
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. This PR appears to mostly meet the NuttX requirements, but is missing some key information. Strengths:
Weaknesses:
Recommendation: The PR author needs to significantly expand the Impact section with specific YES/NO answers and detailed explanations. They also must include the testing logs before and after the change to meet the NuttX requirements fully. |
Summary
fs/littlefs: stop applying local patches for unknown versions of littlefs
Because they are not expected to apply cleanly.
In that case, disable all features which require the local patches.
Note: lfs_util.patch is actually necessary regardless of
the littlefs version. It should be ok to drop it for the simplest
flat memory model configurations with a single heap though. I plan
to fix it once littlefs 2.9.4 is released.
Impact
littlefs
Testing
Tested with esp32s3-devkitc:toywasm + CONFIG_FS_LITTLEFS_VERSION="v2.9.3".
Build-tested linum-stm32h753bi/littlefs with cmake on ubuntu.