risc-v: remove g_running_tasks[this_cpu()] = NULL

[hujun260]

Summary

risc-v: remove g_running_tasks[this_cpu()] = NULL
reason:
We hope to keep g_running_tasks valid forever.

Impact

riscv

Testing

ci ostest
rv-virt:smp

[nuttxpr]

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the basic NuttX requirements, although it could be significantly improved. Here's a breakdown:

Strengths:

• Provides a summary of the change: It explains what is being changed (removing g_running_tasks[this_cpu()] = NULL) and why (to keep g_running_tasks valid).
• Indicates impact: It specifies the affected architecture (RISC-V).
• Includes testing information: It mentions CI, ostest, rv-virt, and smp, suggesting some level of testing has been performed.

Weaknesses (and how to improve them):

• Insufficient detail in the summary: The "how" is missing. How does removing this line keep g_running_tasks valid? What scenario was this line causing problems in? More context is crucial for reviewers.
• Vague impact assessment: Simply stating "riscv" is not enough. Which RISC-V boards? Are there any performance implications? All the "Impact" checklist items should be explicitly addressed (even with "NO" if they don't apply). For example:
  • Impact on user: NO
  • Impact on build: NO
  • Impact on hardware: YES (RISC-V architecture, specifically...)
  • etc.
• Missing testing logs: The PR template specifically requests "Testing logs before change" and "Testing logs after change." These are essential for demonstrating the fix works and doesn't introduce regressions. Placeholder comments are not sufficient; actual logs are required.
• Lack of issue references: If this addresses a specific issue, linking it (even if it's just a local bug you encountered) helps provide context and traceability.

Example of an improved summary:

"risc-v: prevent invalid g_running_tasks entries during context switches

Currently, g_running_tasks[this_cpu()] is set to NULL during context switches. This can lead to issues in scenarios like [briefly describe the scenario, e.g., nested interrupts, certain scheduling edge cases] where code relies on g_running_tasks being consistently valid. This change removes the line setting g_running_tasks[this_cpu()] to NULL, ensuring it always points to the currently running task, even during context switches. This resolves [mention the specific problem being solved, e.g., a crash, incorrect behavior].

Related Issue: [If applicable]"

By addressing these weaknesses, the PR will be much clearer, easier to review, and more likely to be accepted.

[pussuw]

riscv_syscall_dispatch.c must be fixed too?

[hujun260]

riscv_syscall_dispatch.c

done