-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bt_atomic: use small lock in wireless/bluetooth/bt_atomic.c #14985
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No, this PR description does not adequately meet the NuttX requirements. While it provides some information, it's far too brief and lacks crucial details. Here's a breakdown of what's missing:
To be acceptable, the PR description needs significant expansion, providing the missing context and details as outlined in the NuttX requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emm... I might remove bt_atomic.c and replace all of them with stdatomic's API, but this change is also fine for me.
Yes, it's better to remove bt_atomic.c and change bt_atomic to macro to avoid the function invocation cost. |
wireless/bluetooth/bt_atomic.c
Outdated
@@ -35,78 +35,54 @@ | |||
|
|||
bt_atomic_t bt_atomic_incr(FAR bt_atomic_t *ptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: hujun5 <[email protected]>
Summary
bt_atomic: use atomic macro to replace wireless/bluetooth/bt_atomic.c
Impact
bt
Testing
ci