Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: migrate to SPDX identifier #14996

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jerpelea
Copy link
Contributor

Summary

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Impact

SBOM

Testing

CI

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
@github-actions github-actions bot added Arch: renesas Issues related to the Renesas chips Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: sparc Issues related to the SPARC architecture Arch: tricore Issues related to the TriCore architecture from Infineon Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Arch: z16 Issues related to the Z16 architecture Arch: z80 Issues related to the Z80 architecture Size: M The size of the change in this PR is medium labels Nov 29, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 29, 2024

[Experimental Bot, please feedback here]

No, this PR description does not adequately meet the NuttX requirements. While it touches on some points, it lacks crucial details. Here's a breakdown:

  • Summary: While it states the "why," it's vague about the "what" and "how." Which files are changed? How are SPDX identifiers being added? What tools are being targeted? The summary needs more concrete information. Issue/PR references are missing.

  • Impact: Simply stating "SBOM" is insufficient. It needs to address all the listed impact categories with specific "YES/NO" answers and explanations where applicable. For example:

    • Is new feature added? YES (SBOM generation capability)
    • Impact on user? Potentially YES (if SBOM generation becomes part of the build process, users may need to configure it). More details are required.
    • Impact on build? Possibly YES. Needs explanation.
    • ...and so on for all categories.
  • Testing: "CI" is not acceptable. The PR description must include:

    • Specific build host details (OS, CPU architecture, compiler version)
    • Specific target details (architecture, board, configuration)
    • Relevant log snippets demonstrating the functionality before and after the change, not just a general statement about CI. If the change is specifically to facilitate SBOM generation, show how the SBOM output differs before and after the change.

In short, the PR description needs to be significantly expanded to be considered acceptable according to the NuttX requirements. It needs to be more specific and address all the listed points in detail.

@@ -0,0 +1,22 @@
/****************************************************************************
* arch/tricore/src/tc3xx/tc3xx_timerisr.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* arch/tricore/src/tc3xx/tc3xx_timerisr.c
* arch/tricore/src/tc3xx/tc3xx_dummy.c

* under the License.
*
****************************************************************************/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/****************************************************************************
* Private Functions
****************************************************************************/
/* None */
/****************************************************************************
* Public Functions
****************************************************************************/
/* None */

@xiaoxiang781216
Copy link
Contributor

@hartmannathan
Copy link
Contributor

let's fix the style warning: https://github.com/apache/nuttx/actions/runs/12085711167/job/33703502195?pr=14996

The fixes are above, @jerpelea can commit the suggested fixes. It should remove the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: renesas Issues related to the Renesas chips Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: sparc Issues related to the SPARC architecture Arch: tricore Issues related to the TriCore architecture from Infineon Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Arch: z16 Issues related to the Z16 architecture Arch: z80 Issues related to the Z80 architecture Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants