libc/puts: newline was omitted for empty string #15000
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puts("");
did not print a newline. The standardbehavior is to print a newline even if the string
is empty.
Note: Please adhere to Contributing Guidelines.
Summary
From
man 3 puts
on Linux:Impact
Tests that have
puts("")
may fail if they compare stdout against an expected result.Testing
sim:nsh
Should print a newline to
stdout
. Currently, nothing is printed.Edit: Only an issue for the
CONFIG_FILE_STREAM
implementation. When disabled, a newline is included correctly.