-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a few tools/ci/cibuild.sh failures on my environment (macOS 15.1.1, x86-64, xcode 16.1) #15169
Conversation
On my environment PIP_USER doesn't work well. ``` error: externally-managed-environment ``` (macOS 15.1.1, x86-64, xcode 16.1) Also, I prefer to use virtualenv anyway.
This seems to fix build errors on my environment. (macOS 15.1.1, x86-64, xcode 16.1) ``` /Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:45:5: error: use of undeclared identifier 'ABSL_INTERNAL_ASSUME' 45 | ABSL_INTERNAL_ASSUME(hi != 0); | ^ /Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:49:3: error: use of undeclared identifier 'ABSL_INTERNAL_ASSUME' 49 | ABSL_INTERNAL_ASSUME(low != 0); | ^ /Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:141:9: error: redefinition of 'operator/' 141 | uint128 operator/(uint128 lhs, uint128 rhs) { | ^ /usr/local/Cellar/abseil/20240722.0/include/absl/numeric/int128.h:1040:16: note: previous definition is here 1040 | inline uint128 operator/(uint128 lhs, uint128 rhs) { | ^ /Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:152:9: error: redefinition of 'operator%' 152 | uint128 operator%(uint128 lhs, uint128 rhs) { | ^ ```
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a basic summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs to be significantly expanded to meet the NuttX requirements. It requires more specific information in all three sections (Summary, Impact, and Testing). |
Hi @yamt bloaty on github macOS-13 (used on the mirror https://github.com/NuttX/nuttx ) is not built !!! Test while it is ok on github macOS-14 @lupyuen @xiaoxiang781216 |
i have no idea what can cause this error.
|
Summary
fix a few errors i observed with a local run of "./cibuild.sh -i".
Impact
Testing
"./cibuild.sh -i" on my environment. (macOS 15.1.1, x86-64, xcode 16.1)