Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few tools/ci/cibuild.sh failures on my environment (macOS 15.1.1, x86-64, xcode 16.1) #15169

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 13, 2024

Summary

fix a few errors i observed with a local run of "./cibuild.sh -i".

Impact

Testing

"./cibuild.sh -i" on my environment. (macOS 15.1.1, x86-64, xcode 16.1)

yamt added 2 commits December 13, 2024 12:55
On my environment PIP_USER doesn't work well.
```
error: externally-managed-environment
```
(macOS 15.1.1, x86-64, xcode 16.1)

Also, I prefer to use virtualenv anyway.
This seems to fix build errors on my environment.
(macOS 15.1.1, x86-64, xcode 16.1)

```
/Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:45:5: error: use of undeclared identifier 'ABSL_INTERNAL_ASSUME'
   45 |     ABSL_INTERNAL_ASSUME(hi != 0);
      |     ^
/Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:49:3: error: use of undeclared identifier 'ABSL_INTERNAL_ASSUME'
   49 |   ABSL_INTERNAL_ASSUME(low != 0);
      |   ^
/Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:141:9: error: redefinition of 'operator/'
  141 | uint128 operator/(uint128 lhs, uint128 rhs) {
      |         ^
/usr/local/Cellar/abseil/20240722.0/include/absl/numeric/int128.h:1040:16: note: previous definition is here
 1040 | inline uint128 operator/(uint128 lhs, uint128 rhs) {
      |                ^
/Users/yamamoto/git/nuttx/tools/bloaty-src/third_party/abseil-cpp/absl/numeric/int128.cc:152:9: error: redefinition of 'operator%'
  152 | uint128 operator%(uint128 lhs, uint128 rhs) {
      |         ^
```
@github-actions github-actions bot added Area: Tooling Area: CI Size: S The size of the change in this PR is small labels Dec 13, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 13, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a basic summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing:

  • Insufficient Summary: "fix a few errors" is too vague. The summary must describe what errors were fixed, where in the code they were located (e.g., which files/modules), and how they were fixed. It should also include any related NuttX or NuttX Apps issue numbers.

  • Missing Impact Assessment: The entire Impact section is empty. Each point needs to be addressed with a "YES" or "NO" and a description if "YES." This helps reviewers understand the potential consequences of the changes.

  • Incomplete Testing Information: While the build host information is provided, target details are vague. "my environment" isn't sufficient. Specify the exact architecture, board, and configuration used for testing (e.g., sim:nsh). Crucially, the "Testing logs before change" and "Testing logs after change" sections are empty. These logs are essential to demonstrate that the changes fix the identified problems without introducing new issues.

In short, the PR needs to be significantly expanded to meet the NuttX requirements. It requires more specific information in all three sections (Summary, Impact, and Testing).

@xiaoxiang781216 xiaoxiang781216 merged commit fce4f2b into apache:master Dec 13, 2024
27 checks passed
@simbit18
Copy link
Contributor

simbit18 commented Dec 13, 2024

Hi @yamt bloaty on github macOS-13 (used on the mirror https://github.com/NuttX/nuttx ) is not built !!!

Test
macOS-13
https://github.com/simbit18/nuttx-testing-ci/actions/runs/12314027630/job/34369347288

while it is ok on github macOS-14
https://github.com/simbit18/nuttx_test_pr/actions/runs/12313829001/job/34368759832

@lupyuen @xiaoxiang781216
this PR blocks the build on Mirror of Apache NuttX
https://github.com/NuttX/nuttx/actions/runs/12314082720/job/34370749088

@yamt
Copy link
Contributor Author

yamt commented Dec 13, 2024

Hi @yamt bloaty on github macOS-13 (used on the mirror https://github.com/NuttX/nuttx ) is not built !!!

Test macOS-13 https://github.com/simbit18/nuttx-testing-ci/actions/runs/12314027630/job/34369347288

 [470/495] Linking CXX executable bloaty
FAILED: bloaty 
: && /Applications/Xcode_15.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -W -Wall -Wno-sign-compare -fdiagnostics-color=always -O2 -g1 -isysroot /Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk -mmacosx-version-min=13.7 -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/bloaty.dir/src/main.cc.o -o bloaty  liblibbloaty.a  third_party/protobuf/cmake/libprotoc.a  third_party/re2/libre2.a  third_party/capstone/libcapstone.a  /Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/lib/libz.tbd  third_party/abseil-cpp/absl/strings/libabsl_strings.a  third_party/protobuf/cmake/libprotobuf.a  /Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/lib/libz.tbd  third_party/abseil-cpp/absl/strings/libabsl_strings_internal.a  third_party/abseil-cpp/absl/base/libabsl_base.a  third_party/abseil-cpp/absl/base/libabsl_spinlock_wait.a  third_party/abseil-cpp/absl/numeric/libabsl_int128.a  third_party/abseil-cpp/absl/base/libabsl_throw_delegate.a  third_party/abseil-cpp/absl/types/libabsl_bad_optional_access.a  third_party/abseil-cpp/absl/base/libabsl_raw_logging_internal.a  third_party/abseil-cpp/absl/base/libabsl_log_severity.a && :
ld: Undefined symbols:
  absl::debugging_internal::Demangle(char const*, char*, int), referenced from:
      bloaty::ItaniumDemangle(std::__1::basic_string_view<char, std::__1::char_traits<char>>, bloaty::DataSource) in liblibbloaty.a[2](bloaty.cc.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

i have no idea what can cause this error.
but maybe related to this? google/bloaty#385
i submitted a PR to bump bloaty to that verision. #15181

while it is ok on github macOS-14 https://github.com/simbit18/nuttx_test_pr/actions/runs/12313829001/job/34368759832

@lupyuen @xiaoxiang781216 this PR blocks the build on Mirror of Apache NuttX https://github.com/NuttX/nuttx/actions/runs/12314082720/job/34370749088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Tooling Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants