feat(core): not translate to "interrupted" std IO error#7940
Merged
Conversation
Xuanwo
approved these changes
Jul 23, 2026
Xuanwo
left a comment
Member
There was a problem hiding this comment.
Makes sense, thank you for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Hi team, I found when I'm using synchronous IO, it often retries more than I expected. See my regression test for details.
I think the root cause is
std::io::Readis documented to retry on interrupted error: https://web.mit.edu/rust-lang_v1.25/arch/amd64_ubuntu1404/share/doc/rust/html/std/io/trait.Read.html#errorsI think it's not ideal because
What changes are included in this PR?
In this PR, I updated the std IO error from "interrupted" to "other", so it's directly propagated up; I checked OpenDAL errors, no errors should be mapped to "interrupted".
If retry is necessary, users could configure retry wrapper.
Are there any user-facing changes?
No
AI Usage Statement
AI helped me find out the source code.