-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test case for Finish Stemmer
mawiesne
changed the title
OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code.
OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code
Dec 7, 2023
mawiesne
requested changes
Dec 7, 2023
opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java
Outdated
Show resolved
Hide resolved
mawiesne
approved these changes
Dec 7, 2023
Thx for review @mawiesne |
atarora
reviewed
Dec 7, 2023
opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/arabicStemmer.java
Show resolved
Hide resolved
atarora
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow , looks so much cleaner !! Thanks for the great work @rzo1 !!
kinow
approved these changes
Dec 7, 2023
Nicely done, and much quicker than I'd hoped for! Thanks, on behalf of all of our (and your) users! |
jzonthemtn
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
867c4ec70debd4daa7fb4d5a9f7759b47887d0b9
(which has a neat fix for German ;-) )Possible follow-up issue(s):
README.md
and describe how to re-generate the stemmer code.