Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code #561

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 7, 2023

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

  • Regenerates the Snowball Stemmer Java Code with the latest changes from https://github.com/snowballstem/snowball
  • It is based upon 867c4ec70debd4daa7fb4d5a9f7759b47887d0b9 (which has a neat fix for German ;-) )
  • Adds a test case for Finish, which triggered the issue described in OPENNLP-1520 in the old generated code.

Possible follow-up issue(s):

Adds a test case for Finish Stemmer
@mawiesne mawiesne changed the title OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code. OPENNLP-1520 - Re-Generate Snowball Stemmer Java Code Dec 7, 2023
@rzo1 rzo1 requested a review from mawiesne December 7, 2023 14:38
@rzo1
Copy link
Contributor Author

rzo1 commented Dec 7, 2023

Thx for review @mawiesne

Copy link
Contributor

@atarora atarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow , looks so much cleaner !! Thanks for the great work @rzo1 !!

@jonmv
Copy link
Contributor

jonmv commented Dec 7, 2023

Nicely done, and much quicker than I'd hoped for! Thanks, on behalf of all of our (and your) users!

@rzo1 rzo1 merged commit 63ba918 into main Dec 8, 2023
8 checks passed
@rzo1 rzo1 deleted the OPENNLP-1520 branch December 8, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants