Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1530 Add Italian abbreviation dictionary #569

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mawiesne
Copy link
Contributor

Change

  • adds abb_IT.xml to opennlp-tools/lang as provided by Gabriele Vaccari via OPENNLP-1163
  • adds new test cases for the IT localization
  • adjusts and enhances existing test cases with Italian examples from OPENNLP-1163

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

- adds abb_IT.xml to opennlp-tools/lang
- adds new test cases for the IT localization
- adjusts and enhances existing test cases with Italian examples from OPENNLP-1163
@mawiesne mawiesne self-assigned this Dec 18, 2023
@jzonthemtn
Copy link
Contributor

No clue on the Italian part but looks great! :)

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and the abbreviations is from an issue where someone who knows Italian produced. So +1 ! 🎉 thanks @mawiesne !

@mawiesne mawiesne merged commit b74c6df into main Dec 19, 2023
8 checks passed
@mawiesne mawiesne deleted the OPENNLP-1530-Add-Italian-abbreviation-dictionary branch December 19, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants