-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENNLP-1531: Add Portuguese abbreviation dictionary #581
OPENNLP-1531: Add Portuguese abbreviation dictionary #581
Conversation
6d6ac28
to
afa8d96
Compare
Thx @kinow - could you rebase so that PT fits on top of FR changes? |
Nice PT text sample! Code-wise everything looks fine. |
afa8d96
to
b54eff5
Compare
String[] sentSplit = sentence.replaceAll("'", " '").split(" "); | ||
String[] sentSplit = sentence | ||
.replaceAll("'", " '") | ||
.replaceAll(",", " ,") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of my examples failed returning a token as word,
, so I added this extra replace in this test 👍
Done! Tests passed locally for me. |
Easier after the code base has been cleaned up a few times, and especially having some recent examples like the Fr (and also have reviewed the previous PR's you added for other langs). Thanks!!!
🎉 we have everything from the Brazilian Academia de Letras, plus |
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.