Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1661: Fix custom models being wiped from OpenNLP user.home directory #704

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Dec 2, 2024

Change

  • deletes AbstractDownloadUtilTest.java removing historical code that wiped models (accidentally)
  • adds package-private DownloadUtil#existsModel(..) method to check if models of certain language exist locally
  • adds to and adjusts related test classes

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne added the java Pull requests that update Java code label Dec 2, 2024
@mawiesne mawiesne requested review from kinow, jzonthemtn and rzo1 December 2, 2024 19:31
@mawiesne mawiesne self-assigned this Dec 2, 2024
@rzo1
Copy link
Contributor

rzo1 commented Dec 2, 2024

Left some comments, mainly about control flow by exception for NoSuchFileException in exists(...) to avoid opening a connection to get the sha512 hash.

@mawiesne mawiesne force-pushed the OPENNLP-1661-Fix-custom-models-being-wiped-from-OpenNLP-user.home-directory branch from 25fa67a to 76ea1d9 Compare December 3, 2024 04:21
…ectory

- deletes AbstractDownloadUtilTest.java removing historical code that wiped models
- adds package-private DownloadUtil#existsModel(..) method to check models for certain language exist locally
- adds to and adjusts related test classes
@mawiesne mawiesne force-pushed the OPENNLP-1661-Fix-custom-models-being-wiped-from-OpenNLP-user.home-directory branch from 76ea1d9 to b8b65f5 Compare December 3, 2024 04:22
@mawiesne mawiesne requested a review from rzo1 December 3, 2024 04:22
@mawiesne mawiesne changed the title OPENNLP-1661 Fix custom models being wiped from OpenNLP user.home directory OPENNLP-1661: Fix custom models being wiped from OpenNLP user.home directory Dec 3, 2024
@mawiesne mawiesne merged commit e91ceb1 into main Dec 3, 2024
7 checks passed
@mawiesne mawiesne deleted the OPENNLP-1661-Fix-custom-models-being-wiped-from-OpenNLP-user.home-directory branch December 3, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants