Add test cases that guarantee the main execution flows of FPCScheduler. #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style95
requested review from
bdoyle0182,
jiangpengcheng,
KeonHee,
ningyougang and
upgle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5308 +/- ##
==========================================
- Coverage 76.78% 69.39% -7.40%
==========================================
Files 241 241
Lines 14650 14650
Branches 644 644
==========================================
- Hits 11249 10166 -1083
- Misses 3401 4484 +1083 ☔ View full report in Codecov by Sentry. |
4 tasks
style95
force-pushed
the
add-scheduler-flow-tests
branch
from
21cad51
to
5597b98
Compare
bdoyle0182
approved these changes
Feb 12, 2023
|
LGTM |
style95
force-pushed
the
add-scheduler-flow-tests
branch
from
5597b98
to
0c33ab4
Compare
style95
force-pushed
the
add-scheduler-flow-tests
branch
from
83c0d2c
to
32cda4e
Compare
style95
commented
Feb 11, 2024
ansible/group_vars/all
Outdated
| @@ -498,7 +498,7 @@ durationChecker: | |||
| spi: "{{ duration_checker_spi | default('') }}" | |||
| timeWindow: "{{ duration_checker_time_window | default('1 d') }}" | |||
|
|
|||
| enable_scheduler: "{{ scheduler_enable | default(false) }}" | |||
| enable_scheduler: "{{ scheduler_enable | default(true) }}" | |||
There was a problem hiding this comment.
The scheduler test failure of this PR was because the scheduler was not enabled.
As we would enable the scheduler by default with #5463, I rebased this PR from it.
style95
force-pushed
the
add-scheduler-flow-tests
branch
from
32cda4e
to
ea69872
Compare
style95
force-pushed
the
add-scheduler-flow-tests
branch
from
ea69872
to
b9386f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to guarantee the main execution flows with system tests.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: