Enable multiple controllers #5420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5420 +/- ##
==========================================
- Coverage 76.85% 76.75% -0.11%
==========================================
Files 241 241
Lines 14649 14649
Branches 629 629
==========================================
- Hits 11259 11244 -15
- Misses 3390 3405 +15 ☔ View full report in Codecov by Sentry. |
style95
force-pushed
the
enable-multiple-controllers
branch
from
2fbbb71
to
2b41fd1
Compare
style95
commented
May 31, 2023
| ;controller1 ansible_host=172.17.0.1 ansible_connection=local | ||
| ;{% endif %} | ||
| {% if mode is defined and 'HA' in mode %} | ||
| controller1 ansible_host=172.17.0.1 ansible_connection=local |
There was a problem hiding this comment.
This is to enable the second controller in the CI environment to run the HA test for controllers.
style95
force-pushed
the
enable-multiple-controllers
branch
from
0328710
to
06cb30f
Compare
style95
force-pushed
the
enable-multiple-controllers
branch
from
06cb30f
to
daf191a
Compare
|
@ningyougang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to enable multiple controllers on CI tests.
I think it is supposed to be enabled but it was commented at some point.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: