Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3013: Fix potential ClassCastException at reading DELTA_BYTE_ARRAY encoding #3019

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

gszadovszky
Copy link
Contributor

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Closes #3013

@gszadovszky
Copy link
Contributor Author

@wgtmac, if you have some time, could you check this, so we can release it in the next minor one.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gszadovszky!

@bwjoh Could you help verify if this fixes your issue?

@wgtmac wgtmac added this to the 1.14.3 milestone Sep 30, 2024
@wgtmac wgtmac merged commit 96de3f4 into apache:master Sep 30, 2024
9 checks passed
wgtmac pushed a commit that referenced this pull request Sep 30, 2024
@bwjoh
Copy link

bwjoh commented Oct 1, 2024

Thanks for fixing quickly @gszadovszky! I set time aside this week to fix it but you beat me to it. I verified it fixes the issue I came across.

@gszadovszky
Copy link
Contributor Author

Thanks for the verification, @bwjoh. I just fixed it to be included into the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException possible in DeltaByteArrayReader after PARQUET-2431
3 participants