docs: remove stale JDK 11 deprecation comments#1684
Merged
Conversation
Motivation: Java 17 is the project baseline. Comments annotating deprecations introduced "in JDK 11+" or scalac options once unavailable on JDK 11 are now stating the obvious and add noise. Modification: - Drop the trailing `// deprecated in JDK 11+` comment from both `field.isAccessible()` call sites in `PekkoConnectorsResultMapperHelper.scala` (influxdb). The call itself is retained — only the now-redundant deprecation note is removed. - Update stale `// JDK 11 ...` notes in `project/Common.scala` and `build.sbt` to `// project baseline is Java 17: ...` (aligned with apache/pekko#3075 comment style). Result: No behavior change. Comments now reflect the actual Java baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java 17 is the project baseline. Inline
// deprecated in JDK 11+notes and// JDK 11 ...markers annotate facts that are universally known for any Java 17+ reader and add noise. Aligned with the comment style introduced by apache/pekko#3075 ("project baseline is Java 17").Modification
// deprecated in JDK 11+comment from bothfield.isAccessible()call sites ininfluxdb/src/main/scala/.../PekkoConnectorsResultMapperHelper.scala. The calls themselves are retained — only the redundant deprecation note is removed.// JDK 11 ...notes inproject/Common.scala(the commented-out-Xlint:removalscalac option) andbuild.sbt(the influxdb-Wconf:cat=deprecation:ssilencing) to// project baseline is Java 17: ....Result
No behavior change. Comments now reflect the actual Java baseline.
Tests
git diff --check— clean.References
// project baseline is Java 17: ...comment style.