-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure aws-spi-pekko-http integration tests in nightly builds #832
base: main
Are you sure you want to change the base?
Conversation
@pjfanning thanks for running the workflows. For some reason the secret is not being properly propagated. If I look into https://github.com/apache/pekko-connectors/actions/runs/11044846930/job/30681466278, I see that the secret is masked as expected:
However in https://github.com/apache/pekko-connectors/actions/runs/11049659282/job/30695897761?pr=832 it is empty:
I don't have much experience with github actions... |
It looks like there are possibly some restrictions set up so that the access key secret can not be used as an env variable. I'll raise an issue with the ASF Infra team to see if they can give some guidance. This could take a while. |
@pjfanning I reverted all my changes to make sure the secrets can be accessed in a PR. If it works, I will progress from there... |
As I suspected the secrets cannot be accessed in a PR. Can that be changed? |
@jtjeferreira looks like you were right - the secrets seem not to work when you are building for a CI Do you want to remove all the changes and add back the env vars? I can merge it and run the Nightly Build CI job? The env vars seem to be:
|
The ASF Infra team answered and said that GitHub forks of the main project don't have access to the secrets. In theory, I could create a branch on the main project and create a PR off of it. Let me try that. |
As discussed in #827 (comment), this PR configures
aws-spi-pekko-http
integration tests.I understand that S3 module integration tests are setup in a different way (using
@DoNotDiscover
and explicitly callingorg.scalatest.tools.Runner
) , but I don't want to touch for now.I changed the way credentials are passed to use environment variables. I did this, because for the
aws-spi-pekko-http
tests the credentials cannot be configured using JVM system properties, but both tests support environment variables as part of the default credential provider.