Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't link to 'current' pekko docs #603

Merged
merged 1 commit into from
Sep 16, 2024
Merged

don't link to 'current' pekko docs #603

merged 1 commit into from
Sep 16, 2024

Conversation

pjfanning
Copy link
Contributor

link to the version specific docs

Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

At some point the "oldest Pekko version we support" will be older than the "Pekko version we recommend". In that case I think we should build against the "oldest Pekko version we support" but use the "Pekko version we recommend" in the documentation. That's not a problem we need to solve now, though.

@pjfanning pjfanning merged commit c8ea51c into main Sep 16, 2024
10 checks passed
@pjfanning pjfanning deleted the pjfanning-patch-1 branch September 16, 2024 11:46
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants