Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make AddFutureAwaitResult an AnyVal #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 4, 2025

Motivation:
less allocation.

Result:
less allocation

Note: The code it's self seems only been used in tests.

@pjfanning
Copy link
Contributor

mima issue for scala 3 build

[error]  * static method AddFutureAwaitResult(scala.concurrent.Future)org.apache.pekko.http.impl.util.package#AddFutureAwaitResult in class org.apache.pekko.http.impl.util.package has a different result type in current version, where it is scala.concurrent.Future rather than org.apache.pekko.http.impl.util.package#AddFutureAwaitResult
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.http.impl.util.package.AddFutureAwaitResult")

@pjfanning pjfanning added this to the 1.2.0 milestone Jan 9, 2025
@raboof
Copy link
Member

raboof commented Jan 9, 2025

mima issue for scala 3 build

[error]  * static method AddFutureAwaitResult(scala.concurrent.Future)org.apache.pekko.http.impl.util.package#AddFutureAwaitResult in class org.apache.pekko.http.impl.util.package has a different result type in current version, where it is scala.concurrent.Future rather than org.apache.pekko.http.impl.util.package#AddFutureAwaitResult
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.http.impl.util.package.AddFutureAwaitResult")

that is weird, but as this class is private[http] can be safely ignored AFAICS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants