fix: fix javadoc warning in ShoppingCart example#177
Merged
Conversation
…va samples
Motivation:
Two Java sample files use the deprecated Http.bindAndHandle() API,
producing deprecation warnings during compilation.
Modification:
- WeatherHttpServer.java (sharding-java): replace bindAndHandle with
newServerAt("localhost", port).bind(routes), remove unused ConnectHttp,
Materializer and SystemMaterializer imports
- DemoApp.java (cluster-kubernetes-java): replace bindAndHandle with
newServerAt("0.0.0.0", 8080).bind(complete(...)), remove unused
ConnectHttp and Materializer imports
Result:
Samples use the modern HTTP server binding API. No more deprecation
warnings from these files.
Tests:
- sbt compile in pekko-sample-sharding-java (no warnings)
- pekko-sample-cluster-kubernetes-java: not run - pre-existing dependency
resolution issue (Maven project with missing published artifacts)
References: None - cleanup
Motivation:
Javadoc warning: `{@link Summary}` cannot be resolved because `Summary`
is an inner class of `ShoppingCart` and needs the enclosing class prefix.
Modification:
- Replace `{@link Summary}` with `{@link ShoppingCart.Summary}`
Result:
Javadoc warning is eliminated.
Tests:
Not run - docs only
References:
None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Javadoc warning in
pekko-sample-persistence-java/src/main/java/sample/persistence/ShoppingCart.java:{@link Summary}cannot be resolved becauseSummaryis an inner class ofShoppingCartand needs the enclosing class prefixModification
{@link Summary}with{@link ShoppingCart.Summary}Result
Javadoc warning is eliminated.
Tests
Not run - docs only
References
None