fix: add missing space in StageActor PoisonPill/Kill warning message#3040
Merged
Conversation
Motivation: The warning message logged when PoisonPill or Kill is sent to a StageActor was missing a space between the period and the next sentence, resulting in "...not a real Actor.Use a custom..." instead of "...not a real Actor. Use a custom...". Modification: Add the missing space after the period in the warning message in GraphStage.scala, and after the comma in the corresponding test regex in StageActorRefSpec.scala. Result: Warning message reads correctly: "...not a real Actor. Use a custom message type to communicate with it instead." Tests: - sbt "stream-tests / Test / testOnly org.apache.pekko.stream.scaladsl.StageActorRefSpec" — 8/8 References: None - minor formatting fix
Philippus
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The warning message logged when
PoisonPillorKillis sent to aStageActorwas missing a space between the period and the next sentence, resulting in:Modification
Add the missing space after the period in the warning message in
GraphStage.scala, and after the comma in the corresponding test regex inStageActorRefSpec.scala.Result
Warning message reads correctly:
Tests
sbt "stream-tests / Test / testOnly org.apache.pekko.stream.scaladsl.StageActorRefSpec"— 8/8References
None - minor formatting fix