Skip to content

Add TCK tests for replay bounds across a deletion gap#3076

Merged
He-Pin merged 1 commit into
apache:mainfrom
mucciolo:tck-replay-bounds-across-deletion-gap
Jun 16, 2026
Merged

Add TCK tests for replay bounds across a deletion gap#3076
He-Pin merged 1 commit into
apache:mainfrom
mucciolo:tck-replay-bounds-across-deletion-gap

Conversation

@mucciolo

@mucciolo mucciolo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Motivation

PR #517 on pekko-persistence-jdbc added regression tests for replaying messages whose range overlaps a deleted prefix (the gap left by DeleteMessagesTo). @pjfanning asked for the same coverage in the shared TCK so all journal implementations meet one contract.

Test cases

Add five JournalSpec cases. Each deletes messages 1..3 (4..5 survive) and then replays a different window:

  1. lower bound = 3 (last deleted): replays 4, 5
  2. window 1..4 (spans the gap): replays 4
  3. window 1..2 (ends inside the gap): no replay, RecoverySuccess only
  4. window 1..3 (ends at last deleted): no replay, RecoverySuccess only
  5. lower bound = 4 (first survivor): replays 4, 5

Motivation:
pekko-persistence-jdbc apache#517 added regression tests for replaying messages
whose range overlaps a deleted prefix. Port the same coverage to the shared
persistence TCK so all journal implementations meet one contract.

@He-Pin He-Pin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@He-Pin He-Pin added this to the 2.0.0-M4 milestone Jun 16, 2026
@He-Pin He-Pin merged commit 8a09821 into apache:main Jun 16, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants