Skip to content

akka.net licensing for #3063#3112

Closed
pjfanning wants to merge 2 commits into
apache:mainfrom
pjfanning:dotnet-license1
Closed

akka.net licensing for #3063#3112
pjfanning wants to merge 2 commits into
apache:mainfrom
pjfanning:dotnet-license1

Conversation

@pjfanning

Copy link
Copy Markdown
Member

relates to #3063 and the code copied from akkadotnet/akka.net#8264

The Benchmark changes in #3063 seem to be different to the akka.net changes so I just concentrated on Hub and HubSpec changes.

@pjfanning pjfanning requested a review from He-Pin June 20, 2026 13:24
@pjfanning pjfanning added the akkadotnet Issue/PR inspired by Akka.net label Jun 20, 2026
@He-Pin

He-Pin commented Jun 20, 2026

Copy link
Copy Markdown
Member

The code is not copied from it, just the description from the PR. @orange-dot FYI.
I just read your PR's description.

@He-Pin

He-Pin commented Jun 20, 2026

Copy link
Copy Markdown
Member

And the code is not merged yet. The license is belong to @orange-dot

// Copyright (C) 2013-2025 .NET Foundation <https://github.com/akkadotnet/akka.net>
// </copyright>
//-----------------------------------------------------------------------

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code is copied from it....

@He-Pin

He-Pin commented Jun 20, 2026

Copy link
Copy Markdown
Member

I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.

@pjfanning

Copy link
Copy Markdown
Member Author

I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.

@He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.

@He-Pin

He-Pin commented Jun 20, 2026

Copy link
Copy Markdown
Member

revert pr created #3113

@orange-dot

Copy link
Copy Markdown

I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.

@He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.

More than happy, please use it. Thanks.

@He-Pin

He-Pin commented Jun 20, 2026

Copy link
Copy Markdown
Member

@orange-dot Thanks for the comment, can you please comment on the related PR too:) 🫶

@orange-dot

Copy link
Copy Markdown

@He-Pin done :)

@pjfanning

Copy link
Copy Markdown
Member Author

thanks @He-Pin @orange-dot - I'll close this

@pjfanning pjfanning closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

akkadotnet Issue/PR inspired by Akka.net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants