You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.
@He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.
I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.
@He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #3063 and the code copied from akkadotnet/akka.net#8264
The Benchmark changes in #3063 seem to be different to the akka.net changes so I just concentrated on Hub and HubSpec changes.