Adding reentrant locks, for raceconditon caused by connectivity issues #14643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14643 +/- ##
============================================
+ Coverage 61.75% 63.99% +2.24%
- Complexity 207 1608 +1401
============================================
Files 2436 2706 +270
Lines 133233 149225 +15992
Branches 20636 22877 +2241
============================================
+ Hits 82274 95501 +13227
- Misses 44911 46712 +1801
- Partials 6048 7012 +964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // instance even if there is already one. | ||
| LOGGER.warn("Already created"); | ||
| return; | ||
| if (_instance == null) { |
There was a problem hiding this comment.
This is called only once during server starts, which is always single threaded. I don't think we need to synchronize this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an edge case , race condition. When zookeeper connection is broke or takes too long, the synchronzed methods will block all threads .
(bugfix, cleanup)