Add a non-blocking groupBy implementation #14698
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
groupby-optimization
branch
2 times, most recently
from
7fe387a to
0dd717f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14698 +/- ##
============================================
+ Coverage 61.75% 63.81% +2.05%
- Complexity 207 1607 +1400
============================================
Files 2436 2717 +281
Lines 133233 149944 +16711
Branches 20636 22962 +2326
============================================
+ Hits 82274 95682 +13408
- Misses 44911 47233 +2322
- Partials 6048 7029 +981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
groupby-optimization
branch
3 times, most recently
from
caa59d4 to
5eee7a3
Compare
|
@xiangfu0 : are you folks also planning to run some benchmarks? And any other ideas you are already trying out? |
xiangfu0
force-pushed
the
groupby-optimization
branch
15 times, most recently
from
3a1a06c to
530b877
Compare
xiangfu0
force-pushed
the
groupby-optimization
branch
from
530b877 to
758d7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of all threads upsert to single IndexedTable, this approach will try to leverage each thread to generate local groupby result then merge and set.