Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetchPartitionCount and fetchStreamPartitionOffset implementation api for pinot-kinesis #14713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiangfu0
Copy link
Contributor

Implement fetchPartitionCount and fetchStreamPartitionOffset APIs.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (59551e4) to head (78dfda4).
Report is 1505 commits behind head on master.

Files with missing lines Patch % Lines
.../stream/kinesis/KinesisStreamMetadataProvider.java 59.09% 8 Missing and 1 partial ⚠️
.../plugin/stream/kinesis/KinesisConsumerFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14713      +/-   ##
============================================
+ Coverage     61.75%   63.90%   +2.15%     
- Complexity      207     1612    +1405     
============================================
  Files          2436     2714     +278     
  Lines        133233   149693   +16460     
  Branches      20636    22914    +2278     
============================================
+ Hits          82274    95659   +13385     
- Misses        44911    47013    +2102     
- Partials       6048     7021     +973     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.81% <56.52%> (+2.10%) ⬆️
java-21 63.80% <56.52%> (+2.17%) ⬆️
skip-bytebuffers-false 63.86% <56.52%> (+2.11%) ⬆️
skip-bytebuffers-true 63.74% <56.52%> (+36.01%) ⬆️
temurin 63.90% <56.52%> (+2.15%) ⬆️
unittests 63.89% <56.52%> (+2.15%) ⬆️
unittests1 56.23% <ø> (+9.34%) ⬆️
unittests2 34.43% <56.52%> (+6.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants