Fix Storage Quota Utilization Metric Emission for Zero-Sized Segments #14780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please describe how you verified the metrics are actually emitted (maybe a screenshot of the metric in jvisualvm for an integration test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the StorageQuotaChecker to ensure that the storage quota utilization metric is emitted during realtime segment validation. Previously, the metric was skipped for segments with a size of 0, which usually indicates a realtime validation path. Now that storage quota is supported for realtime tables, we need to monitor the metric.
Related PR: Storage quota imposition on realtime tables
Testing
Tested by triggering the RealtimeSegmentValidationManager periodic task within an integration test and using VisualVM to confirm that the
tableStorageQuotaUtilizationis emitted in controller metrics.