Adds metrics for task states #14785
Merged
Adds metrics for task states #14785
+89
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopr
approved these changes
Jan 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14785 +/- ##
============================================
+ Coverage 61.75% 63.88% +2.12%
- Complexity 207 1611 +1404
============================================
Files 2436 2704 +268
Lines 133233 151010 +17777
Branches 20636 23320 +2684
============================================
+ Hits 82274 96466 +14192
- Misses 44911 47329 +2418
- Partials 6048 7215 +1167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
approved these changes
Jan 10, 2025
|
Thanks for adding these metrics. These are table level right ? |
Yes @siddharthteotia there will be table level metrics as well like: |
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional metrics for the available failure states such as DROPPED, TIMED_OUT, TASK_ABORTED.
Requirement came from no alerts for dropped minion tasks.