Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UpsertCompactMergeTask with enableDeletedKeysCompactionConsistency config #14796

Merged

Conversation

tibrewalpratik17
Copy link
Contributor

Small patch to allow UpsertCompactMergeTask along with enableDeletedKeysCompactionConsistency. This helps in setting UpsertCompactMergeTask along with deletedKeysTTL feature.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (59551e4) to head (720a2cc).
Report is 1567 commits behind head on master.

Files with missing lines Patch % Lines
...he/pinot/segment/local/utils/TableConfigUtils.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14796      +/-   ##
============================================
+ Coverage     61.75%   63.83%   +2.07%     
- Complexity      207     1610    +1403     
============================================
  Files          2436     2703     +267     
  Lines        133233   150861   +17628     
  Branches      20636    23290    +2654     
============================================
+ Hits          82274    96295   +14021     
- Misses        44911    47353    +2442     
- Partials       6048     7213    +1165     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.80% <0.00%> (+2.09%) ⬆️
java-21 63.72% <0.00%> (+2.10%) ⬆️
skip-bytebuffers-false 63.82% <0.00%> (+2.07%) ⬆️
skip-bytebuffers-true 63.69% <0.00%> (+35.97%) ⬆️
temurin 63.83% <0.00%> (+2.07%) ⬆️
unittests 63.82% <0.00%> (+2.07%) ⬆️
unittests1 56.34% <0.00%> (+9.45%) ⬆️
unittests2 34.10% <0.00%> (+6.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tibrewalpratik17 tibrewalpratik17 marked this pull request as ready for review January 11, 2025 15:04
@abhioncbr abhioncbr merged commit 863e05f into apache:master Jan 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants