Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance data schema generation for empty response #14918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

This is a followup on #14836 with the following enhancements:

  • Handle MV column type properly
  • Handle the case when different number of columns are returned in single-stage vs multi-stage engine
  • More exception handling to prevent it from throwing exception

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (59551e4) to head (2c3dea9).
Report is 1625 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pinot/query/parser/utils/ParserUtils.java 0.00% 37 Missing ⚠️
...sthandler/BaseSingleStageBrokerRequestHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14918      +/-   ##
============================================
+ Coverage     61.75%   63.74%   +1.99%     
- Complexity      207     1471    +1264     
============================================
  Files          2436     2708     +272     
  Lines        133233   151535   +18302     
  Branches      20636    23398    +2762     
============================================
+ Hits          82274    96600   +14326     
- Misses        44911    47689    +2778     
- Partials       6048     7246    +1198     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.70% <0.00%> (+1.99%) ⬆️
java-21 63.63% <0.00%> (+2.00%) ⬆️
skip-bytebuffers-false 63.71% <0.00%> (+1.97%) ⬆️
skip-bytebuffers-true 63.60% <0.00%> (+35.88%) ⬆️
temurin 63.74% <0.00%> (+1.99%) ⬆️
unittests 63.74% <0.00%> (+1.99%) ⬆️
unittests1 56.33% <0.00%> (+9.44%) ⬆️
unittests2 34.01% <0.00%> (+6.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants