Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding cluster configs in quickstarts #14919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashmayya
Copy link
Collaborator

  • The quickstarts currently allow overriding controller / broker / server / minion configs but not cluster configs.
  • This patch allows overriding cluster configs in quickstarts which is useful to easily test scenarios involving custom cluster configurations.

@yashmayya yashmayya force-pushed the quickstart-cluster-config-override branch from 171838a to d5848d8 Compare January 25, 2025 13:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.73%. Comparing base (59551e4) to head (d5848d8).
Report is 1625 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14919      +/-   ##
============================================
+ Coverage     61.75%   63.73%   +1.98%     
- Complexity      207     1470    +1263     
============================================
  Files          2436     2708     +272     
  Lines        133233   151544   +18311     
  Branches      20636    23400    +2764     
============================================
+ Hits          82274    96590   +14316     
- Misses        44911    47702    +2791     
- Partials       6048     7252    +1204     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.71% <ø> (+2.00%) ⬆️
java-21 63.60% <ø> (+1.98%) ⬆️
skip-bytebuffers-false 63.73% <ø> (+1.98%) ⬆️
skip-bytebuffers-true 63.58% <ø> (+35.86%) ⬆️
temurin 63.73% <ø> (+1.98%) ⬆️
unittests 63.73% <ø> (+1.98%) ⬆️
unittests1 56.32% <ø> (+9.43%) ⬆️
unittests2 34.00% <ø> (+6.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants