New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spring boot 2.5 requires tomcat 9 #559

Merged

shoothzj merged 1 commit into apache:master from bpereto:fix-build

Apr 30, 2024

Contributor

bpereto commented Apr 30, 2024

Motivation

Running the master branch currently fails as there is a depdendency mismatch, spring boot 2.5 requires tomcat 9.

Modifications

Update the gradle dependencies to use tomcat 9
TldParser is required, adding tomcat-embed-core as dependency

Verifying this change

Make sure that the change passes the ./gradlew build checks.


          fix: spring boot 2.5 requires tomcat 9

efd15f0

shoothzj approved these changes

View reviewed changes

Member

shoothzj commented Apr 30, 2024

Thanks for your contribution. It's indeed update to tomcat 9.
https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.5.3/spring-boot-dependencies-2.5.3.pom

shoothzj merged commit 92124ea into apache:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment