[improve][broker] Improve exception for topic does not have schema to check #22974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
type/enhancement
RobertIndie
approved these changes
Jul 1, 2024
dao-jun
approved these changes
Jul 1, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 10, 2024
… check (apache#22974) (cherry picked from commit 4c84788) (cherry picked from commit bbb37b3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
… check (apache#22974) (cherry picked from commit 4c84788) (cherry picked from commit bbb37b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a consumer use schema to connector a active topic with empty(or bytes) schema, will receive
IncompatibleSchemaException: Topic does not have schema to checkBut, This exception message may confuse for users.
Modifications
Failed to add schema to an active topic with empty(BYTES) schema: new schema type schema.getType()Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: