Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][txn] Add admin api getOwnedTransactions #22980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrzzzz
Copy link
Contributor

@hrzzzz hrzzzz commented Jun 26, 2024

PIP: #22982

Motivation

Add an admin API to query the metadata of transactions created by a specific user.

Modifications

Add an admin API to query the metadata of transactions created by a specific user.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added test in: org.apache.pulsar.broker.admin.v3.AdminApiTransactionTest#testGetOwnedTransactions

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: hrzzzz#9

@poorbarcode
Copy link
Contributor

poorbarcode commented Jul 29, 2024

@liangyepianzhou @hrzzzz

Does it relate to a PIP?

@liangyepianzhou
Copy link
Contributor

@hrzzzz Adding a user-facing interface is a breaking change and requires a PIP. Do you mind to write a PIP about this?
You can write the PIP following this. Once you have finished the PIP, we would be like to review it.

@hrzzzz
Copy link
Contributor Author

hrzzzz commented Jul 29, 2024

@hrzzzz Adding a user-facing interface is a breaking change and requires a PIP. Do you mind to write a PIP about this? You can write the PIP following this. Once you have finished the PIP, we would be like to review it.

Thank you for your reply, I have already created a PIP before.
PIP: #22982
discussion thread: https://lists.apache.org/thread/wc4yw1m5g4zywc3c628p5zz4bdkh5x7x

@liangyepianzhou
Copy link
Contributor

Thank you for your reply, I have already created a PIP before.
PIP: #22982
discussion thread: https://lists.apache.org/thread/wc4yw1m5g4zywc3c628p5zz4bdkh5x7x

OK, please put the PIP link in the description of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants