Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [txn] do not take snapshot when no txn. #23009

Closed

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Jul 8, 2024

Motivation

When broker enable txn, but client don't use txn feature, we expect that the tb would't take snapshot. But it did.

Modifications

Guarantee that tb would''t take snapshot.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#61

Copy link

github-actions bot commented Jul 8, 2024

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 8, 2024
Copy link
Contributor

@congbobo184 congbobo184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case we only change handleGetLastMessageId is enough, when producer connect to TB, we should promise that the topic has taken snapshot, otherwise the maxReadPostion is possible not correct, right?

@thetumbled
Copy link
Member Author

in this case we only change handleGetLastMessageId is enough, when producer connect to TB, we should promise that the topic has taken snapshot, otherwise the maxReadPostion is possible not correct, right?

We can take the first snapshot when the transactional producer connected.

@thetumbled
Copy link
Member Author

Another pr try to solve the same problem, close this one.
#21406

@thetumbled thetumbled closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transaction doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants