-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [txn] do not take snapshot when no txn. #23009
[fix] [txn] do not take snapshot when no txn. #23009
Conversation
@thetumbled Please add the following content to your PR description and select a checkbox:
|
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case we only change handleGetLastMessageId is enough, when producer connect to TB, we should promise that the topic has taken snapshot, otherwise the maxReadPostion is possible not correct, right?
We can take the first snapshot when the transactional producer connected. |
Another pr try to solve the same problem, close this one. |
Motivation
When broker enable txn, but client don't use txn feature, we expect that the tb would't take snapshot. But it did.
Modifications
Guarantee that tb would''t take snapshot.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#61