Skip to content

[improve][pip] PIP-391: Enable batch index ACK by default #23567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2024
Merged

[improve][pip] PIP-391: Enable batch index ACK by default #23567

merged 2 commits into from
Nov 14, 2024

Conversation

@BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Nov 6, 2024

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@BewareMyPower BewareMyPower added this to the 4.1.0 milestone Nov 6, 2024
@BewareMyPower BewareMyPower self-assigned this Nov 6, 2024
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 6, 2024
@BewareMyPower
Copy link
Contributor Author

BewareMyPower commented Nov 14, 2024

Now the vote passed, could you help approve this PR? @shibd

@BewareMyPower BewareMyPower merged commit 22cfa54 into apache:master Nov 14, 2024
20 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/pip-391-batch-index-default branch November 14, 2024 04:40
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@BewareMyPower @hanmz
[improve][pip] PIP-391: Enable batch index ACK by default (apache#23567)
4303817
@BewareMyPower BewareMyPower mentioned this pull request Apr 23, 2025
Merged
15 tasks
@lhotari
Copy link
Member

lhotari commented Jun 6, 2025

maxBatchDeletedIndexToPersist is hard coded to 10000. That is make configurable in PR #24392. It will also be useful to enable cursor info compression by default, that's something that we need to consider. PR #24391 adds the values to broker.conf enabling compression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shibd shibd shibd approved these changes

Assignees

@BewareMyPower BewareMyPower

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BewareMyPower @lhotari @shibd