[improve] [pip] PIP-394 Add two interfaces CursorMetadataSerializerProvider and CursorMetadataDeSerializerProvider to support newer or customized cursor metadata serializations #23608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider and CursorMetadataDeSerializerProvider to support newer of customized cursor metadata serializations
poorbarcode
changed the title
poorbarcode
changed the title
|
@poorbarcode How does this compare to the previous work in this area: |
lhotari
reviewed
Nov 18, 2024
lhotari
reviewed
Nov 18, 2024
lhotari
reviewed
Nov 18, 2024
coderzc
reviewed
Dec 4, 2024
| - We call the serialization that implemented before `4.0.0` `V1`, and call after the https://github.com/apache/pulsar/pull/9292 `v2`. | ||
| - Add all version of serialization into `branch-3.0`. | ||
| - Set the default value of `3.0.x` is `V1`, which is the same as the current status. | ||
| - Set the default value of `4.0.x` is `V1`, which is the same as the current status. |
There was a problem hiding this comment.
4.0.0 default serialization is V2?
coderzc
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x