-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] TopicStats specify serialized field name #23621
base: master
Are you sure you want to change the base?
Conversation
@crossoverJie Which Pulsar client and broker version did you experience this with? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for this change. It's also possible that this is a breaking change which requires more thought to address it.
...common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23621 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.79%
- Complexity 32624 34977 +2353
============================================
Files 1877 1944 +67
Lines 139502 147144 +7642
Branches 15299 16226 +927
============================================
+ Hits 102638 109434 +6796
- Misses 28908 29270 +362
- Partials 7956 8440 +484
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lhotari please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#23621 (comment) . We don't want to introduce breaking changes or promote the fields starting with "is"?
Is the duplicate field the only issue?
Yes, just remove the |
Motivation
TopicStats API contains duplicate fields.
Modifications
Use
@JsonProperty("isReplicated")
to specify serialization names.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: