-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][log] Print ZK path if write to ZK fails due to data being too large to persist #23652
base: master
Are you sure you want to change the base?
Conversation
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
@poorbarcode One small detail about the PR titles. Please don't add a space between the 2 prefixes. Instead of |
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
Outdated
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23652 +/- ##
============================================
+ Coverage 73.57% 74.39% +0.82%
- Complexity 32624 35044 +2420
============================================
Files 1877 1944 +67
Lines 139502 147336 +7834
Branches 15299 16258 +959
============================================
+ Hits 102638 109617 +6979
- Misses 28908 29259 +351
- Partials 7956 8460 +504
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation & Modifications
Improvement 1
We can hardly find the ZK node when encountering the above error.
Improvement 2
There is a mechanism that persists cursor ack info into ZK if it matches the two conditions:
But it will print
Error while using MetaStore, try to persist the position...
even if it will not write ZK because there are still messages to consume.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x