-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][admin][branch-2.10] getMessageIdByTimestamp cannot redirect #23658
base: branch-2.10
Are you sure you want to change the base?
[fix][admin][branch-2.10] getMessageIdByTimestamp cannot redirect #23658
Conversation
@@ -122,4 +125,27 @@ public void testTopicLookup(TopicDomain topicDomain, boolean isPartition) throws | |||
Assert.assertEquals(lookupResultSet.size(), 1); | |||
} | |||
|
|||
@Test(timeOut = 30 * 1000) | |||
public void testTopicGetMessageIdByTimestamp() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test don't verify this fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,where is it not covered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should check the 307And404Exception also can return the response exception right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the requested admin address is not the Broker to which the Topic belong, will the result be successful.
however, there is no 404 verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nice cherry pick
Motivation
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Lines 1758 to 1774 in fd7e0b4
L1770 introduced by cherry-pick<#21995>, the forwarding will not be performed.
Modifications
adjust logic
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: