Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Add comment to emphasize using ; as separator in metadataServiceUri. #23665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

visxu
Copy link
Contributor

@visxu visxu commented Dec 2, 2024

[improve] Add comment to emphasize using ; as separator in metadataServiceUri.

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

In bookkeeper.conf, parameter metadataServiceUri miss multiple zk servers example, sometimes take confusing.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

[improve] Add comment to emphasize using `;` as separator in `metadataServiceUri`.
Copy link

github-actions bot commented Dec 2, 2024

@visxu Please select only one documentation label in your PR description.

@github-actions github-actions bot added the doc-complete Your PR changes impact docs and the related docs have been already added. label Dec 2, 2024
@visxu
Copy link
Contributor Author

visxu commented Dec 4, 2024

Hi, @lhotari . Could you help to review it if you're available, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant